[Changelog] Add a note about conformance synthesis in same-file extensions. #16666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
rudkx
reviewed
May 17, 2018
CHANGELOG.md
Outdated
| Code that wants to be as precise as possible should generally not | ||
| conditionally conform to `Codable` directly, but rather its two constituent | ||
| protocols, or else one can only (for instance) decode a `Generic<Param>` if | ||
| `Param` is `Encodable` in additional to the `Decodable`: |
rudkx
reviewed
May 17, 2018
CHANGELOG.md
Outdated
| @@ -57,6 +57,40 @@ Swift 5.0 | |||
| Swift 4.2 | |||
| --------- | |||
|
|
|||
| * [SE-0185][] | |||
|
|
|||
| Protocol conformances can now be synthesized in extensions in the same file as | |||
There was a problem hiding this comment.
I think "can" is right here: the synthesis doesn't always happen.
rudkx
reviewed
May 17, 2018
CHANGELOG.md
Outdated
| struct Generic<Param> { | ||
| var property: Param | ||
| } | ||
| extension Generic: Equatable where Param: Equatable {} |
There was a problem hiding this comment.
If this last part is the auto-synthesized part, it's not clear. You could put it into a comment with something like:
// Automatically synthesized:
// extension Generic...
There was a problem hiding this comment.
Added:
// Automatically synthesized inside the extension:
// static func ==(lhs: Generic, rhs: Generic) -> Bool {
// return lhs.property == rhs.property
// }
rudkx
reviewed
May 17, 2018
CHANGELOG.md
Outdated
|
|
||
| Code that wants to be as precise as possible should generally not | ||
| conditionally conform to `Codable` directly, but rather its two constituent | ||
| protocols, or else one can only (for instance) decode a `Generic<Param>` if |
There was a problem hiding this comment.
"two constituent protocols" -> "two constituent protocols Foo and Bar"
where Foo and Bar are the constituent protocols...
huonw
force-pushed
the
conf-ext-synth-changelog
branch
from
31c8a09 to
d4a9d51
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.