[SR-7501] inlinable misspelling #16667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
jrose-apple
reviewed
May 17, 2018
| @@ -1321,6 +1321,8 @@ ERROR(attr_renamed, none, | |||
| "'@%0' has been renamed to '@%1'", (StringRef, StringRef)) | |||
| WARNING(attr_renamed_warning, none, | |||
| "'@%0' has been renamed to '@%1'", (StringRef, StringRef)) | |||
| ERROR(attr_name_close_match, none, | |||
| "No attribute named '@%0', did you mean '@%1'?", (StringRef, StringRef)) | |||
There was a problem hiding this comment.
Sorry for the late comment, but this should be lowercase! And to be nitpicky, the comma should be a semicolon.
There was a problem hiding this comment.
My bad! I'll submit a new PR with those changes tonight.
jrose-apple
pushed a commit
to jrose-apple/swift
that referenced
this pull request
May 18, 2018
…isspelling [SR-7501] inlinable misspelling (cherry picked from commit 972fac5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a nice error for when
@inlinableis misspelled as@inlineable, and suggests the correct spelling.Resolves SR-7501.