Skip to content

[Python] Make flake8 linting pass without errors/warnings (w/ default rules) #1667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2016
Merged

[Python] Make flake8 linting pass without errors/warnings (w/ default rules) #1667

merged 1 commit into from
Mar 14, 2016

Conversation

practicalswift
Copy link
Contributor

What's in this pull request?

Make flake8 linting pass without errors/warnings (with default rules).

The Python code in the project is now 100 % PEP-8 (Style Guide for Python Code) compliant:

$ pip install flake8
$ flake8
$

Additionally it passed without errors/warnings with common extensions enabled too:

$ pip install flake8 flake8-blind-except flake8-import-order pep8-naming
$ flake8
$

Resolved bug number: –


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

Platform Comment
All supported platforms @swift-ci Please smoke test
OS X platform @swift-ci Please smoke test OS X platform
Linux platform @swift-ci Please smoke test Linux platform

Validation Testing

Platform Comment
All supported platforms @swift-ci Please test
OS X platform @swift-ci Please test OS X platform
Linux platform @swift-ci Please test Linux platform

Note: Only members of the Apple organization can trigger swift-ci.

@practicalswift practicalswift changed the title [Python] Make flake8 linting pass without errors/warning (w/ default rules) [Python] Make flake8 linting pass without errors/warnings (w/ default rules) Mar 13, 2016
@tkremenek
Copy link
Member

@swift-ci Please smoke test

practicalswift added a commit that referenced this pull request Mar 14, 2016
…ult-rules

[Python] Make flake8 linting pass without errors/warnings (w/ default rules)
@practicalswift practicalswift merged commit 7318060 into swiftlang:master Mar 14, 2016
kateinoigakukun pushed a commit to kateinoigakukun/swift that referenced this pull request Sep 7, 2020
[pull] swiftwasm-release/5.3 from release/5.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants