[ClangImporter] Check for API-note-provided attributes by source loc #16704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
Low-priority post-WWDC ping. |
...rather than by whether they're implicit. We're planning to make them explicit (prompted by a change in upstream Clang that no longer prints implicit attributes). rdar://problem/40346997 (Swift side)
jrose-apple
force-pushed
the
explicit-content
branch
from
314d907 to
5a78330
Compare
|
Rebased. @swift-ci Please smoke test |
|
@DougGregor Ping, since we're rebranching Clang. @swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...rather than by whether they're implicit. We're planning to make them explicit in apple/swift-clang#189 (prompted by a change in upstream Clang that no longer prints implicit attributes).
rdar://problem/40346997