[SpaceEngine] intersect cleanups
#16765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esult Based on the `intersect` usage it would be beneficial for it to always return a result in simplified form instead of relying on callers to request simplification. Also as part of this change remove boilerplate code from commutative space intersections e.g. Type ∩ Bool, Unknown ∩ Disjuct.
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
CodaFi
reviewed
May 22, 2018
lib/Sema/TypeCheckSwitchStmt.cpp
Outdated
| PAIRCASE (SpaceKind::UnknownCase, SpaceKind::Constructor): | ||
| return other.intersect(*this, TC, DC); | ||
| PAIRCASE(SpaceKind::UnknownCase, SpaceKind::Type): | ||
| PAIRCASE(SpaceKind::UnknownCase, SpaceKind::Constructor): |
There was a problem hiding this comment.
Nit: Could you put the spaces back?
There was a problem hiding this comment.
Ah, missed that one, thanks!
CodaFi
approved these changes
May 22, 2018
It seems benefitial to have type decomposition into disjunct space as a separate function, because that code is regularly repeated in `intersect`, `isSubspace` and `minus` methods.
xedin
force-pushed
the
more-space-engine-cleanups
branch
from
8c2bb3a to
1101070
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes new
intersectmethod which always returns simplified space and extracteddecomposemethod which returns disjunct from decomposition of the type.