[4.2][Serialization] Allow unbound generic types to cross-reference typeal… #16788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ias decls Ideally `UnboundGenericType` should never be serialized but it is currently allowed to make generic `typealias` declarations without specifying generic parameters, so it should be allowed to cross reference typealias decls in such types as well because `NameAliasType` can't be used until generic parameters are resolved. This is only a temporary fix and more comprehensive solution is still pending here, most likely such declarations should not produce `UnboundGenericType` but instead should copy generic parameters from underlying type and produce proper `NameAliasType`. Resolves: rdar://problem/37384120 (cherry picked from commit 7ed3d75)
xedin
changed the title
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ias decls
Ideally
UnboundGenericTypeshould never be serialized but it iscurrently allowed to make generic
typealiasdeclarations withoutspecifying generic parameters, so it should be allowed to cross
reference typealias decls in such types as well because
NameAliasTypecan't be used until generic parameters are resolved.
This is only a temporary fix and more comprehensive solution is still
pending here, most likely such declarations should not produce
UnboundGenericTypebut instead should copy generic parameters fromunderlying type and produce proper
NameAliasType.Resolves: rdar://problem/37384120
(cherry picked from commit 7ed3d75)