ARC code motion: handle unowned retains/releases correctly. #16817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an assert-crash in the ReleaseHoisting pass. rdar://problem/40525543
|
@swift-ci smoke test and merge |
|
@eeckstein you never describe what the actual error was in the commit message. Why was it crashing? |
|
It was crashing with this assert: Assertion failed: (isRetainInstruction(I) || isReleaseInstruction(I) && "Extracting RC root from invalid instruction"), function getRCRoot, file /Users/erik/proj/swift-work/swift/lib/SILOptimizer/Transforms/ARCCodeMotion.cpp, line 193. because the check for unowned ARC instructions was missing. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an assert-crash in the ReleaseHoisting pass.
rdar://problem/40525543