Skip to content

Revert "Verify that exclusivity access marker producers are well-form… #16823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Revert "Verify that exclusivity access marker producers are well-form… #16823

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions lib/SIL/SILVerifier.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
#include "swift/SIL/DebugUtils.h"
#include "swift/SIL/Dominance.h"
#include "swift/SIL/DynamicCasts.h"
#include "swift/SIL/MemAccessUtils.h"
#include "swift/SIL/PostOrder.h"
#include "swift/SIL/PrettyStackTrace.h"
#include "swift/SIL/SILDebugScope.h"
Expand Down Expand Up @@ -1582,8 +1581,8 @@ class SILVerifier : public SILVerifierBase<SILVerifier> {
}

void checkBeginAccessInst(BeginAccessInst *BAI) {
auto sourceOper = BAI->getOperand();
requireSameType(BAI->getType(), sourceOper->getType(),
auto op = BAI->getOperand();
requireSameType(BAI->getType(), op->getType(),
"result must be same type as operand");
require(BAI->getType().isAddress(),
"begin_access operand must have address type");
Expand All @@ -1604,11 +1603,6 @@ class SILVerifier : public SILVerifierBase<SILVerifier> {
case SILAccessKind::Modify:
break;
}

// For dynamic Read/Modify access, AccessEnforcementWMO assumes a valid
// AccessedStorage and runs very late in the optimizer pipeline.
// TODO: eventually, make this true for any kind of access.
findAccessedStorage(sourceOper);
}

void checkEndAccessInst(EndAccessInst *EAI) {
Expand Down