Skip to content

[func-sig-opts] Add a regression benchmark that shows overhead from +… #16828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions benchmark/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ set(SWIFT_BENCH_MODULES
single-source/BitCount
single-source/ByteSwap
single-source/COWTree
single-source/COWArrayGuaranteedParameterOverhead
single-source/CString
single-source/CSVParsing
single-source/Calculator
Expand Down
42 changes: 42 additions & 0 deletions benchmark/single-source/COWArrayGuaranteedParameterOverhead.swift
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
//===--- COWArrayGuaranteedParameterOverhead.swift ------------------------===//
//
// This source file is part of the Swift.org open source project
//
// Copyright (c) 2014 - 2018 Apple Inc. and the Swift project authors
// Licensed under Apache License v2.0 with Runtime Library Exception
//
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
//
//===----------------------------------------------------------------------===//

import TestsUtils

// This test makes sure that even though we have +0 arguments by default that we
// can properly convert +0 -> +1 to avoid extra COW copies.

public let COWArrayGuaranteedParameterOverhead = BenchmarkInfo(
name: "COWArrayGuaranteedParameterOverhead",
runFunction: run_COWArrayGuaranteedParameterOverhead,
tags: [.regression, .abstraction, .refcount])

@inline(never)
func caller() {
let x = [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12]
blackHole(callee(x))
}

@inline(never)
func callee(_ x: [Int]) -> [Int] {
var y = x
// This should not copy.
y[2] = 27
return y
}

@inline(never)
public func run_COWArrayGuaranteedParameterOverhead(_ N: Int) {
for _ in 0..<N*20000 {
caller()
}
}
2 changes: 2 additions & 0 deletions benchmark/utils/main.swift
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ import BinaryFloatingPointProperties
import BitCount
import ByteSwap
import COWTree
import COWArrayGuaranteedParameterOverhead
import CString
import CSVParsing
import Calculator
Expand Down Expand Up @@ -184,6 +185,7 @@ registerBenchmark(BinaryFloatingPointPropertiesUlp)
registerBenchmark(BitCount)
registerBenchmark(ByteSwap)
registerBenchmark(COWTree)
registerBenchmark(COWArrayGuaranteedParameterOverhead)
registerBenchmark(CString)
registerBenchmark(CSVParsing)
registerBenchmark(CSVParsingAlt)
Expand Down