Skip to content

[4.2] Disable testing printing of subnormals on 32b ARM. (#16433) #16841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2018

Conversation

milseman
Copy link
Member

@milseman milseman commented May 25, 2018

Cherry-pick of #16433

On Darwin (and most other OSes), subnormal support is turned off for armv7, which causes these tests to fail. Longer-term, instead of gating this on architecture we may want to be able to query if subnormals are supported for a BinaryFloatingPoint type, and then we could key off of that instead.

rdar://problem/40454027

On Darwin (and most other OSes), subnormal support is turned off for armv7, which causes these tests to fail. Longer-term, instead of gating this on architecture we may want to be able to query if subnormals are supported for a BinaryFloatingPoint type, and then we could key off of that instead.
@milseman milseman requested review from tbkka and stephentyrone May 25, 2018 18:03
@milseman
Copy link
Member Author

@stephentyrone @tbkka were there any other changes on master that didn't get cherry-picked onto 4.2? I can cherry-pick them here too

@milseman
Copy link
Member Author

@swift-ci please test

@stephentyrone
Copy link
Contributor

This is all I know of.

Copy link
Contributor

@tbkka tbkka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't recall any others.

@tbkka
Copy link
Contributor

tbkka commented May 25, 2018

FWIW, there already is a very simple test for whether subnormals are supported:

  if (Float.leastNonzeroMagnitude != Float.leastNormalMagnitude) {
    // Read this as: "The smallest Float is not the smallest Normal float"
    // ==> Float supports subnormals
  }

@tbkka tbkka merged commit 4569e6b into swiftlang:swift-4.2-branch May 25, 2018
@milseman milseman deleted the 4_2_fix_float_32 branch May 25, 2018 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants