IRGen: Use clangs's LLVM datalayout #16842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It knows better ... rdar://40275689
|
@swift-ci Please test |
|
cc @gottesmm |
|
Thanks! |
jrose-apple
reviewed
May 25, 2018
| @@ -0,0 +1,47 @@ | |||
| ; RUN: %swiftc_driver_plain -frontend -target x86_64-apple-darwin10 -emit-object %s | |||
There was a problem hiding this comment.
Is there a specific reason to use %swiftc_driver_plain -frontend instead of %swift?
slavapestov
reviewed
May 25, 2018
|
|
||
| ; Make sure we update the datalayout with the current clang's. clang knows | ||
| ; better about the ABI intricacies. | ||
| ; This test case woud crash if we did not do this because of i64:128 in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It knows better ...
rdar://40275689