[CMake] Always build the "non-overlay" apinotes #16851
Conversation
|
@swift-ci please test |
|
I think this will build them both ways; it'd really be better to stop building them with the overlays. Or did you want to save that for a follow-up? |
|
Build failed |
|
Closing this, I don't think this is the right solution. |
Rostepher
force-pushed
the
always-build-non-overlay-apinotes
branch
from
07ab9b0 to
04e520f
Compare
Rostepher
force-pushed
the
always-build-non-overlay-apinotes
branch
from
04e520f to
6ab1b3d
Compare
|
@swift-ci test |
|
Build failed |
|
Build failed |
| if (NOT IS_DIRECTORY "${SWIFT_SOURCE_DIR}/stdlib/public/SDK/${framework_name}") | ||
| list(APPEND SWIFTLIB_SINGLE_API_NOTES "${framework_name}") | ||
| endif() | ||
| # Always build the "non-overlay" apinotes to keep them in sync |
There was a problem hiding this comment.
Comment nitpick: this is saying "Always build all API notes", not just the non-overlay ones.
There was a problem hiding this comment.
Well, it's building all the apinotes found in swift/apinotes/, but I can adjust the comment.
Purpose
This PR forces swiftlang to always "rebuild" the "non-overlay" apinotes found in the
apinotesdirectory when compiling.rdar://40496966