[NFC] Never synthesize @lvalue in typing judgements #16856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
Build failed |
xedin
reviewed
May 26, 2018
|
Aha, well I'm going to move the @lvalue synthesis to CSGen where it belongs. |
|
Build failed |
|
Scaling back to just the rule in matchTypes - attacking the keypath rule makes this patch unruly. @swift-ci please smoke test |
Only two more of these exist 1) CSGen's formation of @lvalue -> inout conversion constraints 2) WritableKeyPath's checking rules Both can be eliminated but will require more refactoring.
|
LLDB test timed out @swift-ci please smoke test |
|
@swift-ci please test source compatibility |
|
⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When in a checking context, there is no need (and no sense) in synthesizing
@lvalueinstead of checking the underlying object type.The locators for this typing rule and the other parameter binding one below it are still lying, but probably because there's really no good way to indicate that you're an argument to a function/operator without also lying about the index of the argument - which matchTypes has no way of knowing.