Skip to content

[Test Coverage] Partial revert of 995dec5d82fece0818174fea8c5c22ed438878c5 #16858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2018
Merged

[Test Coverage] Partial revert of 995dec5d82fece0818174fea8c5c22ed438878c5 #16858

merged 1 commit into from
May 26, 2018

Conversation

davezarzycki
Copy link
Contributor

One can use "ObjC interop" without "@objc", therefore test/IRGen/enum.sil should test both. The @objc logic still remains in test/IRGen/enum_objc.sil because #if does not work with SIL keywords/decls.

@davezarzycki
[Test Coverage] Partial revert of 995dec5
52076bf 
One can use "ObjC interop" without "@objc", therefore test/IRGen/enum.sil
should test both. The @objc logic still remains in test/IRGen/enum_objc.sil
because `#if` does not work with SIL keywords/decls.
@davezarzycki
Copy link
Contributor Author

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit ec5b51e into swiftlang:master May 26, 2018
@davezarzycki davezarzycki deleted the better_irgen_test_coverage branch May 26, 2018 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davezarzycki @swift-ci