[NFC] SILGlobalVariable utilities. #16870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test. |
shajrawi
reviewed
May 30, 2018
| } | ||
|
|
||
| SILFunction *swift::getCalleeOfOnceCall(BuiltinInst *BI) { | ||
| assert(BI->getNumOperands() == 2 && "once call should have 2 operands."); |
There was a problem hiding this comment.
Can you please assert based on getBuiltinInfo().ID of the BuiltinInst ? cleaner and safer assertion.
There was a problem hiding this comment.
Will do. This is all super old code that I just move out of SILOptimizer so it can be used to verify well-formed SIL.
shajrawi
reviewed
May 30, 2018
| SingleValueInstruction *&InitVal) { | ||
| InitVal = nullptr; | ||
| SILGlobalVariable *GVar = nullptr; | ||
| // We only handle a single SILBasicBlock for now. |
There was a problem hiding this comment.
I see this comment and this check repeated here and in findInitializer, maybe we can outline it to a single static bool function?
shajrawi
reviewed
May 30, 2018
This information was getting lost in SIL printing/parsing. Some passes rely on it. Regardless of whether passes should rely on it, it is totally unacceptable for the SIL passes to have subtle differences in behavior depending on the frontend mode. So, if we don't want passes to rely on global variable decls, that needs to be enforced by the API independent of how the frontend is invoked or how SIL is serialized.
Move the utilities that are required for recognizing SILGlobalVariable access into SILGlobalVariable.[h|cpp]. Structural SIL properties that are assumed by the optimizer, and thus required for SIL verification, should never be embedded in SILOptimizer passes, or even in SILOptimizer/Utils. Structural SIL properties need to be defined in /SIL. They are as much part of the SIL language as the opcode list. These particular utilities are required for working with SILGlobalVariables, and will be used by a whole-module access enforcement optimization. The primary API for recognizing SIL globals is `getVariableOfGlobalInit`. It is required to find the association between the addressor SILFunction marked [global_init], and the SILGlobalVariable being addressed. Other helper APIs expose more details about the addressor's SIL patterns and are useful for transforming the initializer itself into an optimized form.
|
@swift-ci smoke test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore the first two commits, which are from #16834.
The third commit just moves some code to a place it belongs: Move the utilities that are required for recognizing SILGlobalVariable access into SILGlobalVariable.[h|cpp].
Should be a trivial review. I'm not making a serious attempt to rework the interfaces:
@eeckstein, @gottesmm, @shajrawi ?