[benchmark] Add the ability for a benchmark to specify that it does n… #16872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot run on specific platforms. Today, one can not completely disable a benchmark depending on the platform without changing the source of main.swift. We would like to be able to disable benchmarks locally in a benchmark's file without needing to modify the rest of the infrastructure. The closest that one can get to such behavior is to just conditionally compile out the file locally. But one still will have the test run. This commit adds support for not-running the benchmark on specific platforms. This in combination with conditional compilation of benchmark bodies, allows us to not have to comment out module's in main.swift or have to conditionally compile testinfo. rdar://40541972
|
@swift-ci smoke test and merge |
|
@swift-ci smoke benchmark |
|
I killed the main smoke test and merge part of the job since I went to run a smoke benchmark before this lands. |
Build comment file:Optimized (O)Regression (14)
Improvement (13)
No Changes (411)
Hardware Overview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ot run on specific platforms.
Today, one can not completely disable a benchmark depending on the platform
without changing the source of main.swift. We would like to be able to disable
benchmarks locally in a benchmark's file without needing to modify the rest of
the infrastructure. The closest that one can get to such behavior is to just
conditionally compile out the file locally. But one still will have the test
run.
This commit adds support for not-running the benchmark on specific
platforms. This in combination with conditional compilation of benchmark bodies,
allows us to not have to comment out module's in main.swift or have to
conditionally compile testinfo.
rdar://40541972