-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[benchmark] Move build configuration/sdk configuration out of the main CMakeLists.txt file into AddSwiftBenchmarkSuite.cmake. #16874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gottesmm
merged 2 commits into
swiftlang:master
from
gottesmm:pr-4b615a53246f430a2aa930207041f82738eac2a3
May 29, 2018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…make file. rdar://40541972
…n CMakeLists.txt file into AddSwiftBenchmarkSuite.cmake. I am going to add some support here for Linux. I want to make sure that these changes are hidden from the main CMakeLists.txt file since we want that file to be as declarative as possible. rdar://40541972
@swift-ci smoke test |
@swift-ci smoke benchmark |
Build comment file:Optimized (O)Regression (10)
Improvement (6)
No Changes (422)
Hardware Overview
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am going to add some support here for Linux. I want to make sure that these
changes are hidden from the main CMakeLists.txt file since we want that file to
be as declarative as possible.
rdar://40541972
I also added some small banners to the main CMakesLists.txt file to make it slightly easier to read.