[build-script] SKIP_TEST_BENCHMARK => SKIP_TEST_BENCHMARKS #16878
+9
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
|
Hmmm... I think I uncovered a bug. |
jrose-apple
reviewed
May 29, 2018
| @@ -1398,7 +1398,7 @@ function calculate_targets_for_host() { | |||
| [[ "${build_external_benchmark_this_target}" ]] && | |||
| [[ "${is_in_build_list}" ]] ; then | |||
| SWIFT_BENCHMARK_TARGETS+=("swift-benchmark-${stdlib_deployment_target}-external") | |||
| if [[ $(not ${SKIP_TEST_BENCHMARK}) ]] ; then | |||
There was a problem hiding this comment.
I think this would have been expanding to just not, which is equivalent to false, and then trying to substitute the result, which is if [[ "" ]], which is false. @gparker42, does my shell analysis make sense?
There was a problem hiding this comment.
I don't understand the relevance.
There was a problem hiding this comment.
You're changing this code from always producing false to actually trying to execute something. That's not your fault because the old code is very wrong, but it explains the failure.
There was a problem hiding this comment.
Sorry in my head, I had already gone beyond that. It is actually sort of funny, the reason that today we do not add something here is b/c of another hack in build-script that explicitly states that this typo is why we are doing a workaround... too bad we didn't just fix it = p.
There was a problem hiding this comment.
You're going to have to fix this to get anything to work. LLVM not takes a command name, not a value. (I think the right code here is if [[ ! "${SKIP_TEST_BENCHMARKS}" ]] but I haven't tried it.)
There was a problem hiding this comment.
This is not invoking LLVM not. This is invoking a bash function called not defined in build-script-impl that has exactly what you described as its implementation. See:
There was a problem hiding this comment.
Beyond that do you have anything else?
There was a problem hiding this comment.
Oh wow that's confusing. Then my earlier diagnosis of why things were failing was incorrect. Sorry for wasting your time!
There was a problem hiding this comment.
You didn't waste my time! This is just confusing = p.
Specifically: 1. SKIP_TEST_BENCHMARK => SKIP_TEST_BENCHMARKS I looked for --skip-test-benchmark (notice no s) and SKIP_TEST_BENCHMARK. It seems like it is dead, especially since we have --skip-test-benchmarks. 2. Remove the code that works around SKIP_TEST_BENCHMARK typo.
gottesmm
force-pushed
the
pr-aaef324649673b4468c77d0457c627ecd9d7f743
branch
from
75872ef to
62adeb6
Compare
|
@swift-ci smoke test |
|
@swift-ci smoke benchmark |
|
@swift-ci smoke test |
|
@swift-ci smoke benchmark |
Rostepher
reviewed
May 30, 2018
Build comment file:Optimized (O)Regression (7)
Improvement (10)
No Changes (421)
Hardware Overview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked for --skip-test-benchmark (notice no s) and SKIP_TEST_BENCHMARK. It
seems like it is dead, especially since we have --skip-test-benchmarks.