Implement benchmark testing on Linux #16882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gottesmm
force-pushed
the
pr-efebf52c6733fcc2e617c2ef0b47012cde8c84ec
branch
from
bbd108d to
5a258a7
Compare
|
@swift-ci smoke test |
|
@swift-ci smoke benchmark |
|
Found a mistake... |
gottesmm
force-pushed
the
pr-efebf52c6733fcc2e617c2ef0b47012cde8c84ec
branch
5 times, most recently
from
20239e1 to
7eba5f2
Compare
|
@swift-ci smoke test |
|
@swift-ci smoke benchmark |
|
@swift-ci smoke test |
|
@swift-ci smoke benchmark |
Build comment file:Build failed before running benchmark. |
millenomi
reviewed
May 29, 2018
| @inline(__always) | ||
| func getRandomBuf(_ arg: UnsafeMutableBufferPointer<UInt8>) { | ||
| #if os(Linux) | ||
| fatalError("Unsupported platform") |
There was a problem hiding this comment.
This can build if:
#if canImport(Glibc)
import Glibc
#endif
and:
#if canImport(Glibc)
getrandom(arg.baseAddress, arg.count, 0)
#elseif canImport(Darwin)
// arc4random_buf
#endif
There was a problem hiding this comment.
I can't do this exactly using canImport since this benchmark compiles in swift-3 mode. But I am going to do something similar.
millenomi
reviewed
May 29, 2018
| ] | ||
| #endif | ||
|
|
||
| private var dictionary: [NSString: NSString]! | ||
|
|
||
| private func setup_DictionaryKeysContainsNative() { | ||
| #if os(Linux) |
There was a problem hiding this comment.
These will be supported when #16736 lands.
I was able to run Benchmark_QuickCheck with the out of tree Linux build with just these tests disabled and everything seems to work. rdar://40541972
gottesmm
force-pushed
the
pr-efebf52c6733fcc2e617c2ef0b47012cde8c84ec
branch
from
7eba5f2 to
ca330dd
Compare
|
@swift-ci smoke test |
|
@swift-ci python lint |
gottesmm
force-pushed
the
pr-efebf52c6733fcc2e617c2ef0b47012cde8c84ec
branch
from
ca330dd to
a3229c4
Compare
|
@swift-ci python lint |
|
@swift-ci smoke benchmark |
1 similar comment
|
@swift-ci smoke benchmark |
Build comment file:Build failed before running benchmark. |
millenomi
reviewed
May 29, 2018
| @inline(__always) | ||
| func getRandomBuf(baseAddress: UnsafeMutablePointer<UInt8>, count: Int) { | ||
| #if os(Linux) | ||
| getrandom(arg.baseAddress, arg.count, 0) |
There was a problem hiding this comment.
Now that arg is gone, this will error on Linux.
… on Linux. To use this, one needs to first build an installable root for swift (i.e. like the smoke testbot does). Then use the tool ./benchmark/scripts/build_linux.py with the appropriate locations of the build-directory, installable snapshot, and it will build the benchmarks. (There are more arguments, just use --help). rdar://40541972
gottesmm
force-pushed
the
pr-efebf52c6733fcc2e617c2ef0b47012cde8c84ec
branch
from
a3229c4 to
36e0e69
Compare
|
Instead of defining your own logic for getting random, you can instead try using |
|
@Azoy This benchmark is written in swift-3 mode so that isn't available. Otherwise I would use it. Changing our benchmarks in this way would be a big jump that should be done in a different PR. |
|
@swift-ci smoke test |
|
@swift-ci smoke benchmark |
|
@swift-ci smoke test |
|
@swift-ci smoke benchmark |
Build comment file:Optimized (O)Regression (8)
Improvement (10)
No Changes (420)
Hardware Overview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some notes:
rdar://40541972