Skip to content

ppc64le custom presets. #16884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

asowani
Copy link
Contributor

@asowani asowani commented May 29, 2018

Contains build presets for ppc64le.

@asowani
Copy link
Contributor Author

asowani commented Jun 7, 2018

Can this custom preset be merged to 4.2 branch please? Unless this becomes available, Jenkins build for 4.2 branch cannot be started. Thanks!

@tkremenek
Copy link
Member

@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - ed39f7f

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - ed39f7f

@airspeedswift
Copy link
Member

Is this a merge of a fix from master? If not, the process would normally be to do that first.

@airspeedswift
Copy link
Member

Hi @asowani – is this PR still active or can it be closed? If the goal is to add this support, please add it to master first, then it can be added to 4.2 subsequently via a PR that cherry-picks that change. Thanks!

@asowani
Copy link
Contributor Author

asowani commented Jul 19, 2018

@airspeedswift I will add this change to Master. I am not sure if this PR should be kept open in order to get cherry-picked or can be closed safely. Please advise. Thanks!

@airspeedswift
Copy link
Member

It is probably easiest to close this PR and raise a new one when needed. In fact, is it really necessary to get this change onto 4.2? The branch is almost done at this point so just working on master alone would make more sense if this port is a work-in-progress.

@asowani
Copy link
Contributor Author

asowani commented Jul 20, 2018

@airspeedswift I have already raised a PR for master branch at #16883
This PR is still open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants