Skip to content

[4.2][CSSimplify] When trying to simplify bind with error type fail gracefully #16889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2018

Conversation

xedin
Copy link
Contributor

@xedin xedin commented May 29, 2018

Since member lookup doesn't check requirements
it might sometimes return types which are not
visible in the current context e.g. typealias
defined in constrained extension, substitution
of which might produce error type for base, so
assignement should thead lightly and just fail
if it encounters such types.

Resolves: rdar://problem/39931339
Resolves: SR-5013
(cherry picked from commit 11ba7e0)

@xedin
Copy link
Contributor Author

xedin commented May 29, 2018

@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented May 29, 2018

@swift-ci please test source compatibility

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 244854f074112f8151c6957e444dd5237d35a55d

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 244854f074112f8151c6957e444dd5237d35a55d

…efully

Since member lookup doesn't check requirements
it might sometimes return types which are not
visible in the current context e.g. typealias
defined in constrained extension, substitution
of which might produce error type for base, so
assignement should thead lightly and just fail
if it encounters such types.

Resolves: rdar://problem/39931339
Resolves: SR-5013
(cherry picked from commit 11ba7e0)
@xedin xedin force-pushed the rdar-39931339-4.2 branch from 244854f to c09622c Compare May 29, 2018 21:31
@xedin
Copy link
Contributor Author

xedin commented May 29, 2018

@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented May 29, 2018

@swift-ci please test source compatibility

@swiftlang swiftlang deleted a comment from swift-ci May 29, 2018
@swiftlang swiftlang deleted a comment from swift-ci May 29, 2018
@xedin xedin merged commit a1ec630 into swiftlang:swift-4.2-branch May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants