Skip to content

[GSB] Error types end up as unresolved equivalence classes. #16893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

huonw
Copy link
Contributor

@huonw huonw commented May 29, 2018

We need to make sure they don't end up as "concrete" equivalence
classes, because they behave more like unresolved ones.

Fixes rdar://problem/40009245.

@huonw huonw requested a review from DougGregor May 29, 2018 22:15
@huonw
Copy link
Contributor Author

huonw commented May 29, 2018

@swift-ci please smoke test

We need to make sure they don't end up as "concrete" equivalence
classes, because they behave more like unresolved ones.

Fixes rdar://problem/40009245.
@huonw huonw force-pushed the errors-are-unresolved-equivalence-class branch from ba9b3e4 to 10c3e6c Compare May 29, 2018 23:21
@huonw
Copy link
Contributor Author

huonw commented May 29, 2018

@swift-ci please smoke test

Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@huonw huonw merged commit ec1ed4c into swiftlang:master Jun 4, 2018
@huonw huonw deleted the errors-are-unresolved-equivalence-class branch June 4, 2018 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants