swift-reflection-test: preprocess for windows build #16914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows does not support fork/exec, so preprocess away the calls to those APIs on Windows. This allows for building more of the test binaries.
|
@swift-ci please test and merge |
|
Can you leave comments for why Windows is different? |
|
@jrose-apple - I'm not sure what comments you had in mind. The current implementation is pretty heavily posix, which Win32 is not (even stuff that exists is different from standard unixy implementations, e.g. |
jrose-apple
reviewed
Nov 8, 2018
| @@ -441,6 +453,8 @@ int reflectExistential(SwiftReflectionContextRef RC, | |||
| int doDumpHeapInstance(const char *BinaryFilename) { | |||
| PipeMemoryReader Pipe = createPipeMemoryReader(); | |||
|
|
|||
| #if defined(_WIN32) | |||
There was a problem hiding this comment.
Right here's where I'd want a comment, I think, even if it's just "Windows doesn't have an equivalent to fork, so we'll have to do this in-process."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows does not support fork/exec, so preprocess away the calls to
those APIs on Windows. This allows for building more of the test
binaries.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.