Skip to content

[Sema] Fix a crash in rethrows checking. #16915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2018
Merged

[Sema] Fix a crash in rethrows checking. #16915

merged 1 commit into from
May 31, 2018

Conversation

rudkx
Copy link
Contributor

@rudkx rudkx commented May 30, 2018

We were assuming that variadic parameters are at the end, so we didn't
fill in all the types of the tuple elements in the tuple type we were
constructing.

Fixes: rdar://problem/40472018

We were assuming that variadic parameters are at the end, so we didn't
fill in all the types of the tuple elements in the tuple type we were
constructing.
@rudkx rudkx requested a review from rjmccall May 30, 2018 22:26
@rudkx
Copy link
Contributor Author

rudkx commented May 30, 2018

@swift-ci Please smoke test

@rudkx rudkx merged commit 046f3fc into swiftlang:master May 31, 2018
Copy link
Contributor

@rjmccall rjmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rudkx rudkx deleted the rdar40472018 branch June 1, 2018 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants