[4.2] [sourcekit] Send compile notifications when argument parsing files #16922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g fails For now we don't get a diagnostic, but at least there is a will-compile containing the arguments.
… any reason Refactors the diagnostic code to be run whenever a compilation notification has been started and there are diagnostics available in the consumer. This allows us to capture diagnostics on all exit paths, and specifically when code-completion fails because of invalid arguments. Note: the editor.open code path still doesn't report invalid arguments because it fails before even trying to create an AST.
…ditor.open Since we will not reach `createAST` where we would normally send the notification, send one from `getInvocation` when it fails. rdar://39225180
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #16895
When swift command-line argument parsing fails in sourcekit, make sure we can still send a compile notification including the diagnostic about the incorrect arguments.
rdar://39225180