Fix bugs that caused IRGen to behave differently when debug info was … #16933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test and merge |
|
@swift-ci test and merge |
slavapestov
reviewed
Jun 1, 2018
| /// Force all archetypes referenced by the type to be bound by this point. | ||
| /// TODO: just make sure that we have a path to them that the debug info | ||
| /// can follow. | ||
| void bindArchetypes(swift::Type Ty) { |
There was a problem hiding this comment.
It would be nice if lldb only required type metadata for top-level generic arguments, and not any referenced associated types. Can you file a radar to fix that? It would be feasible to tackle this once you're able to use remote mirrors to calculate layouts (remote mirrors doesn't require metadata instantiation in the target).
adrian-prantl
force-pushed
the
irgen-g
branch
2 times, most recently
from
d3dac0d to
c71c736
Compare
|
@swift-ci test and merge |
…enabled. It hass been a longstanding principle in LLVM that the presence of debug info shall not affect code generation. This patch brings the Swift frontend closer to this ideal: - unconditionally emit shadow copies - unconditionally bind type metadata The extra allocas, bitcasts, geps, and stores being emitted get optimized away when compiling at anything but -Onone. There are few use-cases for compiling at -Onone without -g, so this shouldn't affect performance for any real-world use-cases.
|
@swift-ci test and merge |
1 similar comment
|
@swift-ci test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…enabled.
It hass been a longstanding principle in LLVM that the presence of
debug info shall not affect code generation. This patch brings the
Swift frontend closer to this ideal:
The extra allocas, bitcasts, geps, and stores being emitted get
optimized away when compiling at anything but -Onone. There are few
use-cases for compiling at -Onone without -g, so this shouldn't affect
performance for any real-world use-cases.
rdar://problem/26633363