Skip to content

[Reflection] Fix a member function so that it actually compiles. #16934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2018

Conversation

dcci
Copy link
Member

@dcci dcci commented Jun 1, 2018

Nobody's using it, so nobody noticed. I plan to use this in the
debugger.

Nobody's using it, so nobody noticed. I plan to use this in the
debugger.
@dcci dcci requested a review from slavapestov June 1, 2018 00:03
@dcci
Copy link
Member Author

dcci commented Jun 1, 2018

@swift-ci smoke test and merge

@gottesmm
Copy link
Contributor

gottesmm commented Jun 1, 2018

test?

@dcci
Copy link
Member Author

dcci commented Jun 1, 2018

I can probably change swift-reflection-dump to call this function or we can wait until LLDB uses this or remove the function altogether as nobody uses this. Which one do you prefer?
The reason why I wasn't particularly worried about adding a test is that this function fails to compile without the change, but, yeah, I agree we should considering adding one (or testing this from some consumer).

@swift-ci swift-ci merged commit b7acd02 into swiftlang:master Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants