Skip to content

[Testing Coverage] Enable (not REQUIRE) ObjC interop #16943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2018
Merged

[Testing Coverage] Enable (not REQUIRE) ObjC interop #16943

merged 1 commit into from
Jun 2, 2018

Conversation

davezarzycki
Copy link
Contributor

This improves coverage on Linux. With a little more work, more IRGen tests could use this approach.

@davezarzycki
[Testing Coverage] Enable (not REQUIRE) ObjC interop
db1bb78 
This improves coverage on Linux. With a little more work, more IRGen
tests could use this approach.
@davezarzycki
Copy link
Contributor Author

@swift-ci please smoke test

compnerd
compnerd approved these changes Jun 1, 2018
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly what I had done in a set of previous changes, but had left ones that I couldn't get working quickly. I think that a similar pass on the SILGen tests would be good too.

rjmccall
rjmccall approved these changes Jun 1, 2018
View reviewed changes
Copy link
Contributor

@rjmccall rjmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@davezarzycki davezarzycki merged commit feb3857 into swiftlang:master Jun 2, 2018
@davezarzycki davezarzycki deleted the better_irgen_testing_on_linux branch June 2, 2018 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

@rjmccall rjmccall rjmccall approved these changes

@eeckstein eeckstein eeckstein approved these changes

@jckarter jckarter Awaiting requested review from jckarter

@gribozavr gribozavr Awaiting requested review from gribozavr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davezarzycki @compnerd @rjmccall @eeckstein