[Serialization] Handle llvm::Error in member deserialization recovery #16957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvm::Expected/llvm::Error require that the error is not just checked but explicitly handled. Since we're currently recovering as if nothing happened, we need to use llvm::consumeError to throw the error info away. rdar://problem/40738521
|
@swift-ci Please test |
|
Low-priority post-WWDC ping. |
graydon
approved these changes
Jun 19, 2018
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Jun 19, 2018
…swiftlang#16957) llvm::Expected/llvm::Error require that the error is not just checked but explicitly handled. Since we're currently recovering as if nothing happened, we need to use llvm::consumeError to throw the error info away. rdar://problem/40738521 (cherry picked from commit e840330)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llvm::Expected/llvm::Error require that the error is not just checked but explicitly handled. Since we're currently recovering as if nothing happened, we need to use llvm::consumeError to throw the error info away.
rdar://problem/40738521