[SR-953] Implement Bundle(for: class): Expose SPI to get type descriptor. #16964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
slavapestov
reviewed
Jun 4, 2018
include/swift/Runtime/Metadata.h
Outdated
| #if !SWIFT_OBJC_INTEROP | ||
|
|
||
| SWIFT_CC(swift) SWIFT_RUNTIME_STDLIB_SPI // SPI for swift-corelibs-foundation | ||
| ConstTargetMetadataPointer<swift::InProcess, TargetTypeContextDescriptor> |
There was a problem hiding this comment.
Maybe this should just return a void *, since (at least for now) the callers treat it as an opaque pointer?
There was a problem hiding this comment.
I would have it use const TypeContextDescriptor * instead of the Target template, since this will only ever be used in-process. I don't think there's any harm in having it return the real type here. I also don't think the leading underscore is necessary; IMO this makes sense as a general runtime entry point.
There was a problem hiding this comment.
I'll make those changes.
millenomi
force-pushed
the
bundle-for-class
branch
from
c3ec7a7 to
4c857c5
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion with @jckarter — we would like to have a way, given a class, to get a symbol that originates in the same image (library/shared object/executable etc.) so we can implement
Bundle(for class: AnyClass)in terms ofdladdr(). The type descriptor apparently satisfies this condition for all classes that were compiled AOT.This exposes a C SPI for swift-corelibs-foundation use to obtain the type descriptor given a type.
Resolves SR-953 alongside the patch at swiftlang/swift-corelibs-foundation#1573.