-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[benchmark] Add swiftpm support for the benchmark suite. #16977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gottesmm
merged 1 commit into
swiftlang:master
from
gottesmm:pr-968b0144efee999037465a3d20b909b231109ecc
Jun 4, 2018
Merged
[benchmark] Add swiftpm support for the benchmark suite. #16977
gottesmm
merged 1 commit into
swiftlang:master
from
gottesmm:pr-968b0144efee999037465a3d20b909b231109ecc
Jun 4, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that we can now edit benchmarks in Xcode! Keep in mind: 1. This is not an official build. It is just so we can use Xcode to edit files and get IDE features. 2. I had to do a little hackery to keep the build the way it is today where all single-source files are their own modules. 3. As long as we do not change the directory structure, everything should just update and work since I added a little code that dynamically adds the tests. Also, to do this I had to rename multi-source/PrimsSplit/main.swift => Prims_main.swift. That is because the name main.swift is special in some way and I hit linker errors. By simply changing the name from main.swift => Prims_main.swift, everything is good. I am going to file a separate bug for that.
@swift-ci smoke test |
@swift-ci smoke benchmark |
Build comment file:Optimized (O)Regression (8)
Improvement (11)
No Changes (421)
Hardware Overview
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that we can now edit benchmarks in Xcode! Keep in mind:
and get IDE features.
single-source files are their own modules.
update and work since I added a little code that dynamically adds the tests.
Also, to do this I had to rename multi-source/PrimsSplit/main.swift =>
Prims_main.swift. That is because the name main.swift is special in some way and
I hit linker errors. By simply changing the name from main.swift =>
Prims_main.swift, everything is good. I am going to file a separate bug for
that.
My personal suggestion for using this is to download an os x toolchain and develop an in tree benchmark using that swiftpm.