[AST/ClangImporter] Eliminate layering violation with isInOverlayModuleForImportedModule #16993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leForImportedModule. swiftlang#16951 introduced a layering violation between the AST and ClangImporter libraries; break the layering violation by moving the function isInOverlayModuleForImportedModule() to ClangModuleLoader.
|
@swift-ci please smoke test and merge |
jrose-apple
reviewed
Jun 5, 2018
| return !clangModule->ExportAsModule.empty() && | ||
| clangModule->ExportAsModule == overlayModule->getName().str(); | ||
| clangModule->ExportAsModule == overlayModule->getName().str(); |
There was a problem hiding this comment.
Indentation got messed up here.
| /// overlays of imported modules, e.g., Objective-C bridging conformances. | ||
| virtual bool isInOverlayModuleForImportedModule( | ||
| const DeclContext *overlayDC, | ||
| const DeclContext *importedDC) = 0; |
There was a problem hiding this comment.
Indentation got messed up here (should be double-indented, not right-aligned).
There was a problem hiding this comment.
Double-indentation is awful for function declarations.
There was a problem hiding this comment.
Right-alignment is worse, since it's more likely to change if the function signature changes. But I'm not just applying my own style here; it's LLVM and clang-format style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#16951 introduced a layering violation between the
AST and ClangImporter libraries; break the layering violation by moving the function
isInOverlayModuleForImportedModule() to ClangModuleLoader.