Skip to content

[AST] Resolve fewer decl signatures #16997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 6, 2018
Merged

[AST] Resolve fewer decl signatures #16997

merged 6 commits into from
Jun 6, 2018

Conversation

DougGregor
Copy link
Member

No description provided.

DougGregor added 6 commits June 4, 2018 16:40
@DougGregor
[AST/ClangImporter] Eliminate layering violation with isInOverlayModu…
e1ce0a9 
…leForImportedModule.

swiftlang#16951 introduced a layering violation between the
AST and ClangImporter libraries; break the layering violation by moving the function
isInOverlayModuleForImportedModule() to ClangModuleLoader.
@DougGregor
[AST] Eliminate LazyResolver::resolveDeclSignature() call from the co…
c3ed2de 
…re of name lookup.
@DougGregor
[Clang importer] Fix weird indentation
1b7c491
@DougGregor
[Conformance lookup table] Eliminate an unnecessary use of LazyResolv…
2456868 
…er::resolveDeclSignature()
@DougGregor
Narrow a few LazyResolver::resolveDeclSignature() calls to what they …
bc0445d 
…really need.

Specifically, introduce entrypoints for "resolve overridden decl" and "is @objc". These can
be computed cheaply in many more cases.
@DougGregor
[AST] Eliminate a few more LazyResolver::resolveDeclSignature() calls.
64b1c35
@DougGregor
Copy link
Member Author

@swift-ci please smoke test

@DougGregor
Copy link
Member Author

@swift-ci please test compiler performance

@swift-ci
Copy link
Contributor

swift-ci commented Jun 5, 2018

!!! Couldn't read commit file !!!

@DougGregor
Copy link
Member Author

@swift-ci please smoke test compiler performance

@swift-ci
Copy link
Contributor

swift-ci commented Jun 6, 2018

Build comment file:

Summary for master smoketest

Unexpected test results, excluded stats for ReactiveCocoa

No regressions above thresholds

Debug

debug brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 41,533,758 41,533,076 -682 -0.0%
time.swift-driver.wall 69.5s 69.9s 400.7ms 0.58%

debug detailed

Regressed (0)
name old new delta delta_pct
Improved (1)
name old new delta delta_pct
Sema.NumTypesValidated 209,006 204,353 -4,653 -2.23% ✅
Unchanged (delta < 1.0% or delta < 100.0ms) (22)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 82,886 82,886 0 0.0%
AST.NumLoadedModules 12,485 12,485 0 0.0%
AST.NumTotalClangImportedEntities 254,075 254,055 -20 -0.01%
AST.NumUsedConformances 8,764 8,764 0 0.0%
IRModule.NumIRBasicBlocks 127,605 127,605 0 0.0%
IRModule.NumIRFunctions 75,878 75,878 0 0.0%
IRModule.NumIRGlobals 69,332 69,332 0 0.0%
IRModule.NumIRInsts 1,426,719 1,426,719 0 0.0%
IRModule.NumIRValueSymbols 129,922 129,922 0 0.0%
LLVM.NumLLVMBytesOutput 41,533,758 41,533,076 -682 -0.0%
SILModule.NumSILGenFunctions 44,348 44,348 0 0.0%
SILModule.NumSILOptFunctions 47,339 47,339 0 0.0%
Sema.NumConformancesDeserialized 351,162 351,062 -100 -0.03%
Sema.NumConstraintScopes 900,080 900,068 -12 -0.0%
Sema.NumDeclsDeserialized 2,062,839 2,062,647 -192 -0.01%
Sema.NumDeclsValidated 189,618 188,694 -924 -0.49%
Sema.NumFunctionsTypechecked 47,175 47,175 0 0.0%
Sema.NumGenericSignatureBuilders 80,143 79,983 -160 -0.2%
Sema.NumLazyGenericEnvironments 410,821 410,730 -91 -0.02%
Sema.NumLazyGenericEnvironmentsLoaded 38,010 37,998 -12 -0.03%
Sema.NumLazyIterableDeclContexts 328,061 327,967 -94 -0.03%
Sema.NumTypesDeserialized 2,278,950 2,278,751 -199 -0.01%

Release

release brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 29,579,388 29,579,380 -8 -0.0%
time.swift-driver.wall 143.0s 142.8s -225.4ms -0.16%

release detailed

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (23)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 8,857 8,857 0 0.0%
AST.NumLoadedModules 408 408 0 0.0%
AST.NumTotalClangImportedEntities 25,770 25,770 0 0.0%
AST.NumUsedConformances 8,770 8,770 0 0.0%
IRModule.NumIRBasicBlocks 150,401 150,401 0 0.0%
IRModule.NumIRFunctions 56,829 56,829 0 0.0%
IRModule.NumIRGlobals 53,862 53,862 0 0.0%
IRModule.NumIRInsts 1,241,942 1,241,942 0 0.0%
IRModule.NumIRValueSymbols 101,511 101,511 0 0.0%
LLVM.NumLLVMBytesOutput 29,579,388 29,579,380 -8 -0.0%
SILModule.NumSILGenFunctions 22,181 22,181 0 0.0%
SILModule.NumSILOptFunctions 35,927 35,927 0 0.0%
Sema.NumConformancesDeserialized 85,329 85,329 0 0.0%
Sema.NumConstraintScopes 799,309 799,309 0 0.0%
Sema.NumDeclsDeserialized 204,687 204,687 0 0.0%
Sema.NumDeclsValidated 59,864 59,864 0 0.0%
Sema.NumFunctionsTypechecked 10,716 10,716 0 0.0%
Sema.NumGenericSignatureBuilders 9,623 9,623 0 0.0%
Sema.NumLazyGenericEnvironments 32,167 32,167 0 0.0%
Sema.NumLazyGenericEnvironmentsLoaded 4,548 4,548 0 0.0%
Sema.NumLazyIterableDeclContexts 20,576 20,576 0 0.0%
Sema.NumTypesDeserialized 267,719 267,719 0 0.0%
Sema.NumTypesValidated 34,805 34,805 0 0.0%

@DougGregor DougGregor merged commit d9c0ca9 into swiftlang:master Jun 6, 2018
@DougGregor DougGregor deleted the resolve-fewer-decl-signatures branch June 6, 2018 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DougGregor @swift-ci