Fix regression with inout in enum and subscript signatures #17020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
xedin
reviewed
Jun 6, 2018
There was a problem hiding this comment.
Thanks for looking into this @slavapestov ! It looks like it might be more complicated to fix because now it rejects single argument with inout and no parens...
|
That was just an overzealous cleanup. I can drop one of the patches here. |
…ypes This fixes a 4.2 regression where enums and subscripts could not contain single-argument function types with an 'inout' parameter, because we erroneously diagnosed the 'inout' as if it appeared at the top level of the enum case or subscript index type. Fixes <https://bugs.swift.org/browse/SR-7890>.
…er name We should let Sema set ParamDecl's specifier always, instead of setting it in the parser in this odd corner case where we're recovering from 'inout' being written before the parameter name.
slavapestov
force-pushed
the
enum-subscript-type-resolution
branch
from
832b8bb to
7f9d364
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were overzealously banning 'inout' in enum and subscript signatures. It can actually appear in the argument list of a nested function type.
Fixes https://bugs.swift.org/browse/SR-7890.