[Foundation] adjust inline of append and initialization functions #17027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
@swift-ci please benchmark |
… use _copyContents(initialzing:) to avoid performance regressions while using generic collection/sequence APIs
phausler
force-pushed
the
data_sequence_perf_fix
branch
from
d624c1b to
9a09ab4
Compare
|
@swift-ci please smoke test |
|
@swift-ci please benchmark |
|
@swift-ci please benchmark |
parkera
reviewed
Jun 7, 2018
| @@ -1897,13 +1867,7 @@ extension Data { | |||
|
|
|||
| /// Provides bridging functionality for struct Data to class NSData and vice-versa. | |||
|
|
|||
| #if DEPLOYMENT_RUNTIME_SWIFT | |||
There was a problem hiding this comment.
Is this change orthogonal to the copyContents one?
There was a problem hiding this comment.
Correct but it allows me to iterate on sclf for validating this easily
| var iter = endIterator | ||
| while let byte = iter.next() { self.append(byte) } | ||
| let backing = _DataStorage(capacity: Swift.max(elements.underestimatedCount, 1)) | ||
| var (iter, endIndex) = elements._copyContents(initializing: UnsafeMutableBufferPointer(start: backing._bytes?.bindMemory(to: UInt8.self, capacity: backing._capacity), count: backing._capacity)) |
There was a problem hiding this comment.
cc @atrick to double check the bind here
| @@ -1260,30 +1238,20 @@ public struct Data : ReferenceConvertible, Equatable, Hashable, RandomAccessColl | |||
| } | |||
|
|
|||
| // slightly faster paths for common sequences | |||
|
|
|||
| @inlinable | |||
There was a problem hiding this comment.
Are you sure this @inlinable doesn't expose the _DataStorage type?
There was a problem hiding this comment.
@airspeedswift was telling me this is ok (similar to how Array does it)
| /// Initialize a `Data` with the contents of an Array. | ||
| /// | ||
| /// - parameter bytes: An array of bytes to copy. | ||
| public init(bytes: Array<UInt8>) { |
There was a problem hiding this comment.
The Data perf tests have some cases that cover these specific types, right?
Build comment file:Optimized (O)Regression (7)
Improvement (9)
No Changes (424)
Unoptimized (Onone)Regression (8)
Improvement (12)
No Changes (420)
Hardware Overview |
|
@swift-ci please benchmark |
|
@swift-ci please smoke test |
|
@swift-ci please benchmark |
Build comment file:Optimized (O)Regression (19)
Improvement (6)
No Changes (415)
Unoptimized (Onone)Regression (13)
Improvement (6)
No Changes (421)
Hardware Overview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use _copyContents(initialzing:) to avoid performance regressions while using generic collection/sequence APIs