Revert "[Glibc] Configure modulemap for target, not host" #1703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milseman
added a commit
that referenced
this pull request
Mar 16, 2016
Revert "[Glibc] Configure modulemap for target, not host"
|
@modocache do you know why this would fail in a full build? |
|
Thanks @milseman! This was most likely related to https://github.com/apple/swift/pull/1679/files#r56367942. I'll address that issue, confirm that OS X full builds work for me, then re-submit a pull request. Is there a way to ask @swift-ci to do an OS X full build? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1679
Even though the quick incremental builders are fine, the OS X full builds are erroring out with:
CMake Error at stdlib/public/Glibc/cmake_install.cmake:39 (file):
file INSTALL cannot find
"/Users/buildnode/jenkins/workspace/oss-swift_tools-RA_stdlib-RDA_test-simulator/Ninja-ReleaseAssert/swift-macosx-x86_64/./lib/swift/macosx/x86_64/glibc.modulemap".
Call Stack (most recent call first):
stdlib/public/cmake_install.cmake:37 (include)
stdlib/cmake_install.cmake:32 (include)
cmake_install.cmake:36 (include)