Skip to content

Make algorithms prototype standalone-testable and work with 4.1 #17073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 15, 2018

Conversation

dabrahams
Copy link
Contributor

@swift-ci Please test and merge

@dabrahams dabrahams requested a review from natecook1000 June 8, 2018 23:49
Also,

- strip out currently-unused flotsam
- begin making comments more descriptive
- fix indentation
@dabrahams dabrahams force-pushed the algorithms-standalone branch from 7e7cf91 to ae4ffd1 Compare June 9, 2018 00:24
@dabrahams
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented Jun 9, 2018

Build failed
Swift Test Linux Platform
Git Sha - ae4ffd1

@dabrahams
Copy link
Contributor Author

@swift-ci Please test Linux platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - ae4ffd1

Linux's ld is failing to find the file somehow.
@dabrahams
Copy link
Contributor Author

@swift-ci please test and merge

@dabrahams
Copy link
Contributor Author

@swift-ci Please test Linux platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - ae4ffd1

@dabrahams
Copy link
Contributor Author

@swift-ci Please smoke test OS X platform

@natecook1000
Copy link
Member

@swift-ci Please smoke test

Copy link
Member

@natecook1000 natecook1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dabrahams
Copy link
Contributor Author

@swift-ci Please test Linux platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 0d04dfd

Thanks to @bob-wilson for this fix
@dabrahams
Copy link
Contributor Author

@swift-ci Please test and merge

@swift-ci swift-ci merged commit 3b6d832 into swiftlang:master Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants