Sema: Fix availability of inherited designated initializers [4.2] #17082
+19
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inherited designated initializers got the same availability as the corresponding initialier in the superclass. However if the superclass was more available than the subclass, we would generate a diagnostic that a member cannot be more available than its containing type. This diagnostic had an unknown source location, since the location was for a synthesized declaration, causing confusion. Fixes <https://bugs.swift.org/browse/SR-7881> aka <rdar://problem/40853731>.
|
@swift-ci Please test |
jrose-apple
reviewed
Jun 11, 2018
| } | ||
|
|
||
| @available(OSX, introduced: 10.53) | ||
| class EsotericSmallBatchHipsterThing : WidelyAvailableBase {} |
There was a problem hiding this comment.
Thanks for fixing this! Can you add a test in the opposite direction, where the initializer is 10.53 and the subclass is 10.52? (I know that would break a lot of other things too, but we should have a test for it anyway.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inherited designated initializers got the same availability
as the corresponding initialier in the superclass.
However if the superclass was more available than the subclass,
we would generate a diagnostic that a member cannot be more
available than its containing type.
This diagnostic had an unknown source location, since the
location was for a synthesized declaration, causing confusion.
Fixes https://bugs.swift.org/browse/SR-7881 aka
rdar://problem/40853731.