Minor @inlinable improvements [4.2] #17091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only part of rdar://problem/32722385 I'm going to land in swift-4.2-branch. This will allow code to be written which type checks with both 4.2 and a future release of Swift where a full fix for rdar://problem/32722385 is in place.
…number I want to be able to do an isSwiftVersionAtLeast(4, 2) check.
…ersion 4.2 Normally we don't gate *warnings* on -swift-version flags, but SwiftNIO makes use of @_inlineable / @_versioned and wants to continue building with Swift 4.1 until 4.2 is released. Fixes <https://bugs.swift.org/browse/SR-7578>, <rdar://problem/40717640>.
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@usableFromInlineon typealias declarations, but don't enforce it yet. Enforcement is coming in Check that signatures of @usableFromInline declarations only reference @usableFromInline or public types #16586@_inlineableand@_versionedexcept in -swift-version 4.2 mode (in -swift-version 5 it is still an error). This was an ask from the SwiftNIO team who want to build without warnings on both 4.1 and 4.2 for the time being.