[Exclusivity] Teach separate-stored-property relaxation about TSan instrumentation #17100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Factor out common logic for detecting sanitizer instrumentation and put it in SIL/InstructionUtils.
…strumentation The compile-time exclusivity diagnostics explicitly allow conflicting accesses to a struct when it can prove that the two accesses are used to project addresses for separate stored properties. Unfortunately, the logic that detects this special case gets confused by Thread Sanitizer's SIL-level instrumentation. This causes the exclusivity diagnostics to have false positives when TSan is enabled. To fix this, teach the AccessSummaryAnalysis to ignore TSan builtins when determining whether an access has a single projected subpath. rdar://problem/40455335
|
@swift-ci please smoke test |
|
LGTM |
atrick
approved these changes
Jun 11, 2018
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compile-time exclusivity diagnostics explicitly allow conflicting accesses
to a struct when it can prove that the two accesses are used to project addresses
for separate stored properties. Unfortunately, the logic that detects this special
case gets confused by Thread Sanitizer's SIL-level instrumentation. This causes
the exclusivity diagnostics to have false positives when TSan is enabled.
To fix this, teach the AccessSummaryAnalysis to ignore TSan builtins when
determining whether an access has a single projected subpath.
rdar://problem/40455335