Add reduced crasher for SR-7958 #17103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to use an argument label in an interpolation can cause various crashes. In swiftlang-1000.0.16.7, these are usually in SILGen; in master at 8f6028d, they’re in CSApply.
|
LGTM. You can merge this first and rebase your fix PR after running the fix compiler crashers script or merge the fix first and run the script here. |
CodaFi
reviewed
Jun 11, 2018
| @@ -0,0 +1,10 @@ | |||
| // RUN: %target-swift-frontend -emit-silgen %s | |||
There was a problem hiding this comment.
This should be
// RUN: not --crash %target-swift-frontend %s -emit-ir
|
One last nit and I'll take this. |
|
@CodaFi Should be fixed now. I didn't realize crasher tests passed by still crashing! |
|
@swift-ci test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to use an argument label in an interpolation can cause various crashes. In swiftlang-1000.0.16.7, these are usually in SILGen; in master at 8f6028d, they’re in CSApply.
The file includes two samples. In swiftlang-1000.0.16.7, the first crashes in exactly the same place as the code snippet in SR-7958, while the second crashes elsewhere in SILGen. In master at 8f6028d, they both seem to crash in the same place.