[Foundation] adjust inline of append and initialization functions #17121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… use _copyContents(initialzing:) to avoid performance regressions while using generic collection/sequence APIs
|
@swift-ci please smoke test |
|
@shahmishal do you know what happened here? I branched this from the swift-4.2-branch and it is merge targeting to that branch. |
|
@swift-ci Please smoke test Linux |
|
@parkera I’m pretty sure this belongs in 4.2: do we have to pick this to other branches? |
parkera
approved these changes
Jun 13, 2018
|
I think master and swift-4.2-branch are the two required right now. |
|
@swift-ci please smoke test and merge |
|
I think 4.2 needs full test before merge. |
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use _copyContents(initialzing:) to avoid performance regressions while using generic collection/sequence APIs. This was a regression that was introduced on by ABI stability hardening of Data on the 4.2 and master branches.