Skip to content

[ConstraintSystem] Allow LValues for the bindings of an IUO @optional… #17136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2018
Merged

[ConstraintSystem] Allow LValues for the bindings of an IUO @optional… #17136

merged 1 commit into from
Jun 12, 2018

Conversation

rudkx
Copy link
Contributor

@rudkx rudkx commented Jun 12, 2018

… requirement.

We were failing to bind the alternatives for an IUO @optional
requirement because we forgot to set the appropriate type variable option.

Fixes: rdar://problem/40868990

…requirement.

We were failing to bind the alternatives for an IUO @optional
requirement because we forgot to set the appropriate type variable option.

Fixes: rdar://problem/40868990
@rudkx
Copy link
Contributor Author

rudkx commented Jun 12, 2018

@swift-ci Please smoke test

@rudkx
Copy link
Contributor Author

rudkx commented Jun 12, 2018

@swift-ci Please test source compatibility

@rudkx rudkx requested a review from xedin June 12, 2018 07:38
Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But that’s scary...

@rudkx
Copy link
Contributor Author

rudkx commented Jun 12, 2018

@swift-ci Please smoke test Linux platform

@rudkx
Copy link
Contributor Author

rudkx commented Jun 12, 2018

@xedin I think this is really just a straightforward mistake in an odd corner case, so hopefully not at all scary.

@rudkx
Copy link
Contributor Author

rudkx commented Jun 12, 2018

@swift-ci Please smoke test Linux platform

@rudkx rudkx merged commit 197593b into swiftlang:master Jun 12, 2018
@rudkx rudkx deleted the rdar40868990 branch June 12, 2018 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants