Skip to content

[SILGen] Don't force thunks for Clang declarations to be serialized #17146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2018

Conversation

jrose-apple
Copy link
Contributor

They "may be serialized", not "must be serialized". Small compile-time win (and helps decrease the frequency of SIL bugs around mixing Swift versions).

@jrose-apple jrose-apple requested a review from slavapestov June 12, 2018 20:13
@jrose-apple
Copy link
Contributor Author

@swift-ci Please test

@jrose-apple
Copy link
Contributor Author

@swift-ci Please test source compatibility

Copy link
Contributor

@slavapestov slavapestov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 29ddeaa99754a07d467cb873f76e17e03a748c5a

They "may be serialized", not "must be serialized". Small compile-time
win (and helps decrease the frequency of SIL bugs around mixing Swift
versions).
@jrose-apple
Copy link
Contributor Author

Full Mac tests
Source compat suite

@swift-ci Please smoke test

@jrose-apple jrose-apple merged commit 7148de5 into swiftlang:master Jun 12, 2018
@jrose-apple jrose-apple deleted the mustnt branch June 12, 2018 22:31
@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 29ddeaa99754a07d467cb873f76e17e03a748c5a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants