[Serialization] Implement serialization for @differentiable attribute. #17155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test tensorflow |
dan-zheng
force-pushed
the
serialize-autodiff-attr
branch
2 times, most recently
from
db622e5 to
1c1e89c
Compare
Implement (de)serialization for all components of `@differentiable` attribute except the trailing where clause (which needs to be type-checked). This is a necessary step for the `#adjoint` expression to look up `@differentiable` attributes declared on functions in other modules correctly. Addresses SR-7977.
dan-zheng
force-pushed
the
serialize-autodiff-attr
branch
from
1c1e89c to
d4da28d
Compare
rudkx
reviewed
Jun 12, 2018
| DeclIDField, // Adjoint function declaration. | ||
| BCArray<BCFixed<32>> // Differentiation parameters. | ||
| >; | ||
|
|
There was a problem hiding this comment.
VERSION_MINOR in this file needs to be bumped.
There was a problem hiding this comment.
Thanks! Done in d7ea8bc.
dan-zheng
force-pushed
the
serialize-autodiff-attr
branch
from
6cce8ef to
d7ea8bc
Compare
rxwei
approved these changes
Jun 12, 2018
| @@ -55,7 +55,7 @@ const uint16_t VERSION_MAJOR = 0; | |||
| /// describe what change you made. The content of this comment isn't important; | |||
| /// it just ensures a conflict if two people change the module format. | |||
| /// Don't worry about adhering to the 80-column limit for this line. | |||
| const uint16_t VERSION_MINOR = 405; // SWIFT_ENABLE_TENSORFLOW: graph_op. | |||
| const uint16_t VERSION_MINOR = 406 // SWIFT_ENABLE_TENSORFLOW: serialize @differentiable. | |||
| for (auto paramValue : paramValues) { | ||
| auto parameter = paramValue & 0x01 | ||
| ? AutoDiffParameter::getSelfParameter(SourceLoc()) | ||
| : AutoDiffParameter::getIndexParameter(SourceLoc(), paramValue>>1); |
There was a problem hiding this comment.
Done, minor refactoring to keep things within 80 cols.
I too love spaces around operators.
Address comments from @rxwei.
|
@swift-ci Please test tensorflow |
|
@swift-ci Please test tensorflow |
marcrasi
pushed a commit
that referenced
this pull request
Jun 14, 2018
#17155) Implement (de)serialization for all components of `@differentiable` attribute except the trailing where clause (which needs to be type-checked). This is a necessary step for the `#adjoint` expression to look up `@differentiable` attributes declared on functions in other modules correctly. Addresses SR-7977.
marcrasi
pushed a commit
to google/swift
that referenced
this pull request
Jun 15, 2018
swiftlang#17155) Implement (de)serialization for all components of `@differentiable` attribute except the trailing where clause (which needs to be type-checked). This is a necessary step for the `#adjoint` expression to look up `@differentiable` attributes declared on functions in other modules correctly. Addresses SR-7977.
marcrasi
pushed a commit
that referenced
this pull request
Jun 22, 2018
#17155) Implement (de)serialization for all components of `@differentiable` attribute except the trailing where clause (which needs to be type-checked). This is a necessary step for the `#adjoint` expression to look up `@differentiable` attributes declared on functions in other modules correctly. Addresses SR-7977.
marcrasi
pushed a commit
that referenced
this pull request
Jun 28, 2018
#17155) Implement (de)serialization for all components of `@differentiable` attribute except the trailing where clause (which needs to be type-checked). This is a necessary step for the `#adjoint` expression to look up `@differentiable` attributes declared on functions in other modules correctly. Addresses SR-7977.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement serialization/deserialization for all components of
@differentiableattribute except the trailing where clause (which needs to be type-checked).This is a necessary step for the
#adjointexpression to look up@differentiableattributes declared on functions in other modules.Addresses SR-7977.