build: switch to CMake for XCTest #17180

compnerd · 2018-06-13T19:05:47Z

Now that XCTest has a CMake build system, use that for the non-Darwin
builds. This sets the stage for building Foundation with CMake.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

compnerd · 2018-06-13T19:06:12Z

CC: @briancroom @modocache @gottesmm

compnerd · 2018-06-13T19:06:44Z

Please test with following PR:
swiftlang/swift-corelibs-xctest#215

@swift-ci please test

swift-ci · 2018-06-13T19:10:39Z

Build failed
Swift Test OS X Platform
Git Sha - 06eee5287e34038646de4b1c90d209b3e55029df

swift-ci · 2018-06-13T19:11:01Z

Build failed
Swift Test Linux Platform
Git Sha - 06eee5287e34038646de4b1c90d209b3e55029df

modocache · 2018-06-13T19:18:56Z

utils/build-script-impl

+                    -DENABLE_TESTING=YES
+                  )
+                ;;
+                easc


typo, I think? s/easc/esac/ -- maybe that's why the build failed?

Ugh, right-e-o.

compnerd · 2018-06-14T04:02:37Z

@swift-ci please test

swift-ci · 2018-06-14T04:05:50Z

Build failed
Swift Test OS X Platform
Git Sha - 06eee5287e34038646de4b1c90d209b3e55029df

swift-ci · 2018-06-14T04:35:12Z

Build failed
Swift Test Linux Platform
Git Sha - 184c41e9f9805c0d45cadf5eb3a433c14f7dc105

modocache · 2018-06-14T13:16:35Z

Now it looks like the SwiftPM tests Linux are failing due to not being able to import XCTest... I wonder if they expect the build products to be someplace they're not, sort of like what happened in swiftlang/swift-corelibs-xctest#215 ?

compnerd · 2018-06-14T15:59:17Z

@modocache - yeah, that would be my guess, seems that the layout might be different :-(

compnerd · 2018-06-14T16:37:31Z

Ah, I see, the cmake builds have placed the swift content under a swift directory rather than the top level.

compnerd · 2018-06-14T16:54:29Z

Please test with following PR:
swiftlang/swift-corelibs-xctest#216

@swift-ci please test Linux platform

swift-ci · 2018-06-14T17:30:59Z

Build failed
Swift Test Linux Platform
Git Sha - 184c41e9f9805c0d45cadf5eb3a433c14f7dc105

compnerd · 2018-06-17T17:02:31Z

CC: @aciidb0mb3r - any idea why s-p-m fails to find xctest?

lanza · 2018-06-25T21:29:25Z

@swift-ci please test Linux platform

compnerd · 2018-06-28T17:41:55Z

@swift-ci please test Linux platform

swift-ci · 2018-06-28T18:15:02Z

Build failed
Swift Test Linux Platform
Git Sha - 184c41e9f9805c0d45cadf5eb3a433c14f7dc105

compnerd · 2018-07-19T22:27:04Z

@swift-ci please test Linux platform

swift-ci · 2018-07-19T23:06:10Z

Build failed
Swift Test Linux Platform
Git Sha - 184c41e9f9805c0d45cadf5eb3a433c14f7dc105

compnerd · 2018-08-15T20:47:01Z

@swift-ci please test

swift-ci · 2018-08-15T23:12:02Z

Build failed
Swift Test Linux Platform
Git Sha - 1eefac0fb0968b339c5f8b3772d224cd779f7bd4

lanza · 2018-08-22T02:14:47Z

Please test with following pull request:
swiftlang/swift-corelibs-xctest#220

@swift-ci Please test Linux platform

swift-ci · 2018-08-22T03:37:56Z

Build failed
Swift Test Linux Platform
Git Sha - 1eefac0fb0968b339c5f8b3772d224cd779f7bd4

compnerd · 2018-08-22T17:08:13Z

@swift-ci please test Linux platform

swift-ci · 2018-08-22T19:02:39Z

Build failed
Swift Test Linux Platform
Git Sha - 1eefac0fb0968b339c5f8b3772d224cd779f7bd4

compnerd · 2018-08-27T22:25:08Z

@swift-ci please test Linux platform

swift-ci · 2018-08-27T23:32:24Z

Build failed
Swift Test Linux Platform
Git Sha - 1eefac0fb0968b339c5f8b3772d224cd779f7bd4

Now that XCTest has a CMake build system, use that for the non-Darwin builds. This sets the stage for building Foundation with CMake.

compnerd · 2018-08-29T17:25:13Z

@swift-ci please test

swift-ci · 2018-08-29T17:25:14Z

Build failed
Swift Test OS X Platform
Git Sha - 1eefac0fb0968b339c5f8b3772d224cd779f7bd4

swift-ci · 2018-08-29T18:39:07Z

Build failed
Swift Test Linux Platform
Git Sha - 519595d

compnerd · 2018-08-29T23:24:54Z

@swift-ci please test Linux platform

swift-ci · 2018-08-30T00:43:07Z

Build failed
Swift Test Linux Platform
Git Sha - 519595d

gottesmm · 2018-09-01T18:18:57Z

I was able to build this on linux locally. I think we may have a dependency problem (not sure). Lets try a clean build to see if my intuition is right.

gottesmm · 2018-09-01T18:19:22Z

To be clear, if I am correct that this is a dependency problem, we should eliminate that dependency problem first before this merges.

gottesmm · 2018-09-01T18:19:28Z

@swift-ci clean test linux platform

swift-ci · 2018-09-01T19:36:59Z

Build failed
Swift Test Linux Platform
Git Sha - 519595d

gottesmm · 2018-09-05T18:59:45Z

@swift-ci test linux platform

gottesmm · 2018-09-05T18:59:52Z

@swift-ci test linux platform

gottesmm · 2018-09-05T19:00:09Z

Log was eliminating. I am re-starting the incremental build to see if we can reproduce on the bots again.

swift-ci · 2018-09-05T20:37:23Z

Build failed
Swift Test Linux Platform
Git Sha - 519595d

compnerd · 2018-09-19T19:37:57Z

@swift-ci please test

swift-ci · 2018-09-19T20:57:46Z

Build failed
Swift Test Linux Platform
Git Sha - 519595d

compnerd · 2018-09-20T01:53:07Z

@swift-ci please test linux platform

swift-ci · 2018-09-20T03:05:32Z

Build failed
Swift Test Linux Platform
Git Sha - 519595d

compnerd · 2018-09-21T00:02:56Z

@swift-ci please test linux platform

swift-ci · 2018-09-21T02:31:34Z

Build failed
Swift Test Linux Platform
Git Sha - 519595d

compnerd · 2018-09-21T04:09:28Z

Please test with following PR:
swiftlang/swift-corelibs-xctest#224

@swift-ci please test

gottesmm · 2018-09-21T17:18:00Z

@compnerd congrats!

jrose-apple · 2018-09-24T17:06:51Z

Looks like XCTest is no longer getting rebuilt when the standard library changes. What can we do about that?

jrose-apple · 2018-09-24T19:55:23Z

https://bugs.swift.org/browse/SR-8826

modocache reviewed Jun 13, 2018

View reviewed changes

compnerd force-pushed the xctest-cmake branch from 06eee52 to 184c41e Compare June 13, 2018 20:15

compnerd force-pushed the xctest-cmake branch from 184c41e to 1eefac0 Compare August 15, 2018 20:45

lanza mentioned this pull request Aug 22, 2018

Change typod add_custom_target to add_custom_command swiftlang/swift-corelibs-xctest#220

Merged

build: switch to CMake for XCTest

519595d

Now that XCTest has a CMake build system, use that for the non-Darwin builds. This sets the stage for building Foundation with CMake.

compnerd force-pushed the xctest-cmake branch from 1eefac0 to 519595d Compare August 29, 2018 17:24

compnerd merged commit f8d2745 into swiftlang:master Sep 21, 2018

compnerd deleted the xctest-cmake branch September 21, 2018 17:01

gottesmm mentioned this pull request Sep 24, 2018

[SR-8826] XCTest - error: undefined reference to '$ss37_HashableTypedNativeDictionaryStorageCMa' swiftlang/swift-corelibs-xctest#360

Closed

build: switch to CMake for XCTest #17180

build: switch to CMake for XCTest #17180

Uh oh!

Conversation

compnerd commented Jun 13, 2018

Uh oh!

compnerd commented Jun 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

compnerd commented Jun 13, 2018

Uh oh!

swift-ci commented Jun 13, 2018

Uh oh!

swift-ci commented Jun 13, 2018

Uh oh!

modocache Jun 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

compnerd Jun 13, 2018

Choose a reason for hiding this comment

Uh oh!

compnerd commented Jun 14, 2018

Uh oh!

swift-ci commented Jun 14, 2018

Uh oh!

swift-ci commented Jun 14, 2018

Uh oh!

modocache commented Jun 14, 2018

Uh oh!

compnerd commented Jun 14, 2018

Uh oh!

compnerd commented Jun 14, 2018

Uh oh!

compnerd commented Jun 14, 2018

Uh oh!

swift-ci commented Jun 14, 2018

Uh oh!

compnerd commented Jun 17, 2018

Uh oh!

lanza commented Jun 25, 2018

Uh oh!

compnerd commented Jun 28, 2018

Uh oh!

swift-ci commented Jun 28, 2018

Uh oh!

compnerd commented Jul 19, 2018

Uh oh!

swift-ci commented Jul 19, 2018

Uh oh!

compnerd commented Aug 15, 2018

Uh oh!

swift-ci commented Aug 15, 2018

Uh oh!

lanza commented Aug 22, 2018

Uh oh!

swift-ci commented Aug 22, 2018

Uh oh!

compnerd commented Aug 22, 2018

Uh oh!

swift-ci commented Aug 22, 2018

Uh oh!

compnerd commented Aug 27, 2018

Uh oh!

swift-ci commented Aug 27, 2018

Uh oh!

compnerd commented Aug 29, 2018

Uh oh!

swift-ci commented Aug 29, 2018

Uh oh!

swift-ci commented Aug 29, 2018

Uh oh!

compnerd commented Aug 29, 2018

Uh oh!

swift-ci commented Aug 30, 2018

Uh oh!

gottesmm commented Sep 1, 2018

Uh oh!

gottesmm commented Sep 1, 2018

Uh oh!

compnerd commented Jun 13, 2018 •

edited

Loading

modocache Jun 13, 2018 •

edited

Loading