Skip to content

[IDE] Scrub SwiftIDE of References to getInput() #17181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2018

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Jun 13, 2018

Does what it says on the tin. Unblocked a bit of refactoring and flushed some dead code in the process.

@CodaFi CodaFi requested review from nkcsgexi and benlangmuir June 13, 2018 19:29
@CodaFi
Copy link
Contributor Author

CodaFi commented Jun 13, 2018

@swift-ci please smoke test

@CodaFi CodaFi force-pushed the in-put-up-and-in-shut-up branch from 64d496a to d77682c Compare June 13, 2018 20:03
@CodaFi
Copy link
Contributor Author

CodaFi commented Jun 13, 2018

Missed the API digester tests locally

@swift-ci please smoke test

@nkcsgexi
Copy link
Contributor

Could we avoid changing the index dumped from the api-digester? We need to teach the migrator part to incorporate such change.

@CodaFi CodaFi force-pushed the in-put-up-and-in-shut-up branch from d77682c to e8eba29 Compare June 13, 2018 21:44
@CodaFi
Copy link
Contributor Author

CodaFi commented Jun 13, 2018

@nkcsgexi Had a chat with @nathawes about this. I'm pulling the API digester changes into a separate patch.

@nkcsgexi
Copy link
Contributor

@CodaFi thank you!

@CodaFi
Copy link
Contributor Author

CodaFi commented Jun 13, 2018

@swift-ci please smoke test

@CodaFi
Copy link
Contributor Author

CodaFi commented Jun 15, 2018

@swift-ci please smoke test and merge

@CodaFi
Copy link
Contributor Author

CodaFi commented Jun 16, 2018

@swift-ci please smoke test Linux platform

@CodaFi
Copy link
Contributor Author

CodaFi commented Jun 16, 2018

⛵️

@CodaFi CodaFi merged commit a7c9bd0 into swiftlang:master Jun 16, 2018
@CodaFi CodaFi deleted the in-put-up-and-in-shut-up branch June 16, 2018 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants