[TypeReconstruction] Fix reconstruction for existential metatypes. #17184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcci
commented
Jun 13, 2018
| @@ -6,4 +6,5 @@ $Ss10CollectionP7Element ---> Can't resolve type of $Ss10CollectionP7Element | |||
| $Ss15ContiguousArrayV9formIndex5afterySiz_tFSS_Tg5 ---> (inout Int) -> () | |||
| $S12TypeReconstr8PatatinoaySiGD ---> Patatino<Int> | |||
| $S7ElementQzD ---> τ_0_0.Element | |||
| $S13EyeCandySwift21_previousUniqueNumber33_ADC08935D64EA4F796440E7335798735LLs6UInt64Vvp -> UInt64 | |||
| $S13EyeCandySwift21_previousUniqueNumber33_ADC08935D64EA4F796440E7335798735LLs6UInt64Vvp ---> UInt64 | |||
There was a problem hiding this comment.
While I was around, I also fixed this typo (of my own creation).
|
@swift-ci please test and merge |
slavapestov
approved these changes
Jun 13, 2018
|
|
||
| if (type_result.HasSingleType()) | ||
| result._types.push_back( | ||
| ExistentialMetatypeType::get(type_result._types[0], metatype_repr)); |
There was a problem hiding this comment.
Should you check that type_result._types is nonempty?
There was a problem hiding this comment.
I think the non-emptiness it's already guaranteed as part of HasSingleType, which is defined as:
bool HasSingleType() { return _types.size() == 1 && _types.front(); }
Without this, we wouldn't be able to show an array of `Any.Type` in the debugger. Fixes <rdar://problem/40940701>.
dcci
force-pushed
the
existentialmetareco
branch
from
230957e to
ec40a54
Compare
|
@swift-ci test and merge |
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, we wouldn't be able to show an array of
Any.Typein the debugger.
Fixes rdar://problem/40940701.