Implicit tuple interpolations, take two #17195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keeps them from being interpreted as parameter lists. Fixes SR-7958.
beccadax
changed the title
|
Thanks! |
|
@swift-ci Please smoke test |
Lesson learned: the script is not infallible.
|
Mind running that again? I guess I shouldn't put too much faith in the resolve-crashes script. |
|
resolve-crashes could be a bit smarter here, definitely. @swift-ci please smoke test |
|
@swift-ci please test source compatibility |
|
Let's try this again ⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the parser encounters a "weird" string interpolation, like
\(x, y)or\(foo: x), it sometimes produces aTupleExprinstead of aParenExpr. This change wraps any suchTupleExprs inParenExprs to keep them from being interpreted as argument lists. This doesn't stop us from getting strange nodes like single-expression labeled tuples, but at least they're strange in ways that the compiler can cope with, and unlike #17074, this solution doesn't appear to cause any source breakage.I'll post on Evolution soon about how to deal with these interpolations on a more permanent basis.
Resolves SR-7958 (again).
cc @CodaFi