Skip to content

SourceKit: enable lld for libdispatch if used #17201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

compnerd
Copy link
Member

If we are using lld for building swift, enable lld for the libdispatch
build as well.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@compnerd
Copy link
Member Author

@swift-ci please test and merge

@compnerd
Copy link
Member Author

@swift-ci please clean test Linux platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - ded9dfdbf1676984c1c2e7ec06baae6b79dc2483

@compnerd
Copy link
Member Author

Bleh, seems that somehow gold and lld are being enabled simultaneously.

@compnerd
Copy link
Member Author

Please test with following PR:
swiftlang/swift-corelibs-libdispatch#370

@swift-ci please test Linux platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - ded9dfdbf1676984c1c2e7ec06baae6b79dc2483

@compnerd
Copy link
Member Author

Please test with following PR:
swiftlang/swift-corelibs-libdispatch#370

@swift-ci please test Linux platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - ded9dfdbf1676984c1c2e7ec06baae6b79dc2483

This enables building lld to ensure that we are able to build it in our
toolchain.  This does not change the linker used for any of the builds.
@compnerd compnerd closed this Nov 4, 2019
@compnerd compnerd deleted the lld branch November 4, 2019 17:33
@compnerd compnerd restored the lld branch November 4, 2019 17:33
@compnerd compnerd deleted the lld branch November 4, 2019 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants